Clever Code or Foolish Functions?

In an attempt to be more efficient (and because I apparently have the short-term memory of a goldfish) I've developed some code to go at the end of my procedure for adding new login accounts for T_CUST_LOGIN while tending to the T_NEXT_ID table that I always seem to forget to update.  The code is as follows:

UPDATE T_NEXT_ID
SET T_NEXT_ID.next_id = (select max(eaddress_no) from T_EADDRESS)
where T_NEXT_ID.type='AD' and (select next_id from T_NEXT_ID where type='AD') <> (select max(eaddress_no) from T_EADDRESS)

What do you think, Tessiturians?  It should work, right?

BONUS ICHTHYOCENTRIC TRIVIA: The oldest recorded age of a goldfish is 41.

Parents
  • Hi Matt,
     
    I always use the stored procedure AP_GET_NEXTID.
     
    EXECUTE AP_GET_NEXTID @type='AD',@increment=1

    Lisa

    --

    Original Message -----

    Sent: Tuesday, June 08, 2010 1:05 PM
    Subject: [Tessitura Technical Forum] Clever Code or Foolish Functions?

    In an attempt to be more efficient (and because I apparently have the short-term memory of a goldfish) I've developed some code to go at the end of my procedure for adding new login accounts for T_CUST_LOGIN while tending to the T_NEXT_ID table that I always seem to forget to update.  The code is as follows:

    UPDATE T_NEXT_ID
    SET T_NEXT_ID.next_id = (select max(eaddress_no) from T_EADDRESS)
    where T_NEXT_ID.type='AD' and (select next_id from T_NEXT_ID where type='AD') <> (select max(eaddress_no) from T_EADDRESS)

    What do you think, Tessiturians?  It should work, right?

    BONUS ICHTHYOCENTRIC TRIVIA: The oldest recorded age of a goldfish is 41.




    This message was sent automatically to you by www.tessituranetwork.com because you subscribed to the Tessitura Technical Forum. You may reply to this message to post to the Technical forum or visit the site to search, read and post to the forums. In the interest of keeping the forum posts from becoming cluttered, we encourage you to delete previous message text from your reply before sending. Thank you!
Reply
  • Hi Matt,
     
    I always use the stored procedure AP_GET_NEXTID.
     
    EXECUTE AP_GET_NEXTID @type='AD',@increment=1

    Lisa

    --

    Original Message -----

    Sent: Tuesday, June 08, 2010 1:05 PM
    Subject: [Tessitura Technical Forum] Clever Code or Foolish Functions?

    In an attempt to be more efficient (and because I apparently have the short-term memory of a goldfish) I've developed some code to go at the end of my procedure for adding new login accounts for T_CUST_LOGIN while tending to the T_NEXT_ID table that I always seem to forget to update.  The code is as follows:

    UPDATE T_NEXT_ID
    SET T_NEXT_ID.next_id = (select max(eaddress_no) from T_EADDRESS)
    where T_NEXT_ID.type='AD' and (select next_id from T_NEXT_ID where type='AD') <> (select max(eaddress_no) from T_EADDRESS)

    What do you think, Tessiturians?  It should work, right?

    BONUS ICHTHYOCENTRIC TRIVIA: The oldest recorded age of a goldfish is 41.




    This message was sent automatically to you by www.tessituranetwork.com because you subscribed to the Tessitura Technical Forum. You may reply to this message to post to the Technical forum or visit the site to search, read and post to the forums. In the interest of keeping the forum posts from becoming cluttered, we encourage you to delete previous message text from your reply before sending. Thank you!
Children